[Frontend] Delegate tokenization serving preprocessing to OpenAIServingRender#37266
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Mar 17, 2026
Merged
Conversation
…ngRender Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
sagearc
requested review from
DarkLight1337,
aarnphm,
chaunceyjiang,
njhill and
russellb
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the initialization and usage of the OpenAIServingRender component. The OpenAIServingRender instance is now created centrally in api_server.py's init_app_state function, rather than in api_router.py's init_generate_state. Subsequently, the OpenAIServingTokenization service is updated to accept and utilize this OpenAIServingRender instance, delegating chat template validation and prompt preprocessing methods (_validate_chat_template, _preprocess_chat, _preprocess_completion) to it, thereby improving modularity and separation of concerns.
sagearc
requested review from
NickLucche and
robertgshaw2-redhat
as code owners
DarkLight1337
approved these changes
Mar 17, 2026
github-actions
bot
added
the
ready
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
andylolu2
pushed a commit
to andylolu2/vllm
that referenced
this pull request
Mar 18, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…ngRender (vllm-project#37266) Signed-off-by: Sage Ahrac <sagiahrak@gmail.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
OpenAIServingRender(#36166) is the canonical, engine-free home for request preprocessing. #36483 wired it intoOpenAIServingChatandOpenAIServingCompletion, butOpenAIServingTokenizationwas left calling the duplicate copies onOpenAIServingdirectly. This PR continues that cleanup by delegating tokenization serving preprocessing toOpenAIServingRender, and moves its construction toinit_app_stateso it's available to all serving classes from the start.OpenAIServingTokenizationnow delegates the following methods toopenai_serving_renderinstead of calling theOpenAIServingbase class copies:_validate_chat_template_preprocess_chat_preprocess_completionOpenAIServingRenderconstruction is moved out ofinit_generate_stateintoinit_app_stateso it's available earlier and shared across all serving classes.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.